Merges vibe-coded branch onto master + fixes 1667 for unix - #106
Open
qwertyenthusiast wants to merge 8 commits into
Open
Merges vibe-coded branch onto master + fixes 1667 for unix#106qwertyenthusiast wants to merge 8 commits into
qwertyenthusiast wants to merge 8 commits into
Conversation
…but hey `tools/run-auxtest.sh linux-516.1667` passes.
Absolucy
previously requested changes
Jun 10, 2026
ZeWaka
reviewed
Jun 10, 2026
added 2 commits
June 13, 2026 18:03
Author
|
so, it turns out, it didn't make me do stuff any faster. whoops. it should be good now, though. |
qwertyenthusiast
marked this pull request as ready for review
June 21, 2026 14:50
Absolucy
requested changes
Jul 23, 2026
| } } | ||
|
|
||
| fn auxtools_init_impl() -> Option<String> { | ||
| colog::init(); |
Collaborator
There was a problem hiding this comment.
stick this behind a Once or something - else partial inits may explode.
Comment on lines
+103
to
+105
| if (call_proc_by_id_hook(&ret, proc_instance->usr, proc_type, proc_instance->proc_id, unk_0, proc_instance->src, proc_instance->args, proc_instance->args_count, 0, 0)) { | ||
| clean(ret); | ||
| *out = ret; |
Collaborator
There was a problem hiding this comment.
i think this might be skipping the ProcInstance cleanup and leaking a bunch of shit
the 1647 executor normally releases usr/src, drops + frees the args, frees the context, and calls the callback before returning
| uint32_t argslist_idx; | ||
| uint32_t unk_1; | ||
| uint32_t unk_2; | ||
| uint32_t unk_3; |
Collaborator
There was a problem hiding this comment.
struct might not be right, at least on linux.
i think this ends up treating the args pointer as the count, and the first inline arg as a pointer.
don't quote me on this tho, double-check it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the vibe-coded branch with a bunch of tweaks to make auxtools work with 516.1667. Only 516 versions were tested, and I'm aware that some 516 builds don't match the signatures; I'm just finishing a script to automatically compare repo signatures against library files before actually fixing those signatures. I'm just making this PR right now in hopes to actually incentivize me to stop procrastinating and for someone to review the changes.
Do poke me on Discord if you want the AGENTS.md gone or something else in the commit.